Improve sig snippet to display alias statement #10212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riknoll
previously requested changes
Oct 1, 2024
There was a problem hiding this comment.
code looks good! however, please leave the remove-at-statement.md file.
our docs are served "live-ish" from this repo and so changing this now will break existing targets that don't have your change to the help annotation in pxt-core.d.ts. this file can be removed once this change has been propagated to other editors.
ganicke
reviewed
Oct 1, 2024
|
@ganicke is this good to merge? |
ganicke
approved these changes
Oct 16, 2024
ganicke
dismissed
riknoll’s stale review
removal of '_remove-at-statement.md' is reverted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before @ganicke 's PR (#10078), alias statements have same reference (or help doc) as original statements have.
Thanks to his PR,
_removeAtStatement(alias forremoveAt) has an original page, but it is not altogether good, I guess.For blocks users,
removeAtand_removeAtStatementlooks different statements, but they are essentially the same.And of course, JavaScript/Python users shouldn't use
_removeAtStatement.So, I suggest to improve sig snippet to display alias statement.
And anyway
_popStatement,_shiftStatementand_unshiftStatement(as_removeAtStatement) should have thier reference.@ganicke @abchatra